Remove failing security checks #1254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
maybe instead of removing it we can tell travis that it is ok if it fails. see allow_failures something like: ...
jobs:
allow_failures:
- stage: security scan 🔐
script: npm run test:redos
node_js: lts/*
... |
Member
Author
|
@UziTech Whoa I had no idea you could do that. Do you want to make a new PR and I'll just close this one? |
Member
|
ya sounds good. I'll work on that tonight |
6 tasks
Member
Author
|
Closing...this is superseded by #1256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.