Define path with __dir__ (jekyll#6087)

Merge pull request 6087
markdownGO · Jul 25, 2017 · 8f1959b · 8f1959b
1 parent 8a017b5
commit 8f1959b
Show file tree

Hide file tree

Showing 13 changed files with 19 additions and 19 deletions.
diff --git a/Gemfile b/Gemfile
@@ -27,8 +27,8 @@ group :test do
   gem "rspec"
   gem "rspec-mocks"
   gem "rubocop", "~> 0.49.1"
-  gem "test-dependency-theme", :path => File.expand_path("./test/fixtures/test-dependency-theme", File.dirname(__FILE__))
-  gem "test-theme", :path => File.expand_path("./test/fixtures/test-theme", File.dirname(__FILE__))
+  gem "test-dependency-theme", :path => File.expand_path("test/fixtures/test-dependency-theme", __dir__)
+  gem "test-theme", :path => File.expand_path("test/fixtures/test-theme", __dir__)
 
   gem "jruby-openssl" if RUBY_ENGINE == "jruby"
 end

diff --git a/Rakefile b/Rakefile
@@ -4,7 +4,7 @@ require "rdoc"
 require "date"
 require "yaml"
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "lib"))
+$LOAD_PATH.unshift File.expand_path("lib", __dir__)
 require "jekyll/version"
 
 Dir.glob("rake/**.rake").each { |f| import f }

diff --git a/exe/jekyll b/exe/jekyll
@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 STDOUT.sync = true
 
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
 
 require "jekyll"
 require "mercenary"

diff --git a/jekyll.gemspec b/jekyll.gemspec
@@ -1,6 +1,6 @@
 # coding: utf-8
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "jekyll/version"
 

diff --git a/lib/jekyll.rb b/lib/jekyll.rb
@@ -1,12 +1,12 @@
-$LOAD_PATH.unshift File.dirname(__FILE__) # For use/testing when no gem is installed
+$LOAD_PATH.unshift __dir__ # For use/testing when no gem is installed
 
 # Require all of the Ruby files in the given directory.
 #
 # path - The String relative path from here to the directory.
 #
 # Returns nothing.
 def require_all(path)
-  glob = File.join(File.dirname(__FILE__), path, "*.rb")
+  glob = File.join(__dir__, path, "*.rb")
   Dir[glob].sort.each do |f|
     require f
   end

diff --git a/lib/jekyll/commands/new.rb b/lib/jekyll/commands/new.rb
@@ -113,7 +113,7 @@ def create_sample_files(path)
         end
 
         def site_template
-          File.expand_path("../../site_template", File.dirname(__FILE__))
+          File.expand_path("../../site_template", __dir__)
         end
 
         def scaffold_path

diff --git a/lib/jekyll/commands/serve.rb b/lib/jekyll/commands/serve.rb
@@ -234,7 +234,7 @@ def start_callback(detached)
 
         private
         def mime_types
-          file = File.expand_path("../mime.types", File.dirname(__FILE__))
+          file = File.expand_path("../mime.types", __dir__)
           WEBrick::HTTPUtils.load_mime_types(file)
         end
       end

diff --git a/script/console b/script/console
@@ -1,10 +1,10 @@
 #!/usr/bin/env ruby
 
 require 'pry'
-$LOAD_PATH.unshift File.join(File.dirname(__FILE__), *%w{ .. lib })
+$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
 require 'jekyll'
 
-TEST_DIR = File.expand_path(File.join(File.dirname(__FILE__), *%w{ .. test }))
+TEST_DIR = File.expand_path("../test", __dir__)
 
 def fixture_site(overrides = {})
   Jekyll::Site.new(site_configuration(overrides))

diff --git a/script/stackprof b/script/stackprof
@@ -3,10 +3,10 @@
 require "bundler/setup"
 require "json"
 require "stackprof"
-require File.expand_path("../../lib/jekyll", __FILE__)
+require File.expand_path("../lib/jekyll", __dir__)
 
 MODE = ARGV.first || "cpu"
-PROF_OUTPUT_FILE = File.expand_path("../../tmp/stackprof-#{MODE}-#{Time.now.strftime("%Y%m%d%H%M")}.dump", __FILE__)
+PROF_OUTPUT_FILE = File.expand_path("../tmp/stackprof-#{MODE}-#{Time.now.strftime("%Y%m%d%H%M")}.dump", __dir__)
 
 puts "Stackprof Mode: #{MODE}"
 

diff --git a/script/vendor-mimes b/script/vendor-mimes
@@ -5,7 +5,7 @@
 require 'json'
 require 'open-uri'
 
-config = File.expand_path "../lib/jekyll/mime.types", File.dirname(__FILE__)
+config = File.expand_path "../lib/jekyll/mime.types", __dir__
 
 # Create an array of vendored mimetype => [extensions]
 mimes = {}

diff --git a/test/helper.rb b/test/helper.rb
@@ -13,7 +13,7 @@ def jruby?
   require "simplecov"
   SimpleCov.start
 else
-  require File.expand_path("../simplecov_custom_profile", __FILE__)
+  require File.expand_path("simplecov_custom_profile", __dir__)
   SimpleCov.start "gem" do
     add_filter "/vendor/gem"
     add_filter "/vendor/bundle"
@@ -63,7 +63,7 @@ def refute_exist(filename, msg = nil)
 
 module DirectoryHelpers
   def root_dir(*subdirs)
-    File.join(File.dirname(File.dirname(__FILE__)), *subdirs)
+    File.expand_path(File.join("..", *subdirs), __dir__)
   end
 
   def dest_dir(*subdirs)

diff --git a/test/test_convertible.rb b/test/test_convertible.rb
@@ -6,11 +6,11 @@ class TestConvertible < JekyllUnitTest
     setup do
       @convertible = OpenStruct.new(
         "site" => Site.new(Jekyll.configuration(
-          "source" => File.expand_path("../fixtures", __FILE__)
+          "source" => File.expand_path("fixtures", __dir__)
         ))
       )
       @convertible.extend Jekyll::Convertible
-      @base = File.expand_path("../fixtures", __FILE__)
+      @base = File.expand_path("fixtures", __dir__)
     end
 
     should "parse the front matter correctly" do

diff --git a/test/test_new_command.rb b/test/test_new_command.rb
@@ -9,7 +9,7 @@ def dir_contents(path)
   end
 
   def site_template
-    File.expand_path("../lib/site_template", File.dirname(__FILE__))
+    File.expand_path("../lib/site_template", __dir__)
   end
 
   context "when args contains a path" do