Changed object to dict conversion to included 'false' Boolean values #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The issue I encountered was when creating a new time entry via POST to '/time/entries' (REST API Time Documentation: Create Time Entry.) The API default value for '
addToDetailDescriptionFlag
' is 'True
.'The following code can be used to reproduce the error:
When converting the
TimeEntry
object to a dict in the method_create
, will not include any object attribute that was purposely set toFalse
. Thus, it will later not be included in the POST which results in the value " "addToDetailDescriptionFlag": False
" not actually being POSTed to the API endpoint.Reach out if you got any questions!
Regards,
Philipp