Skip to content

Conversation

@mtjhax
Copy link

@mtjhax mtjhax commented Mar 19, 2021

Configatron::Store#fetch with a falsey default should set and return that default. At the moment it sets and returns nil, for example:

configatron.configure_from_hash(test_config: {})
=> {:test_config=>{}}
configatron.test_config.fetch(:enabled, false)
=> nil

One would expect the result to be false. This could be a breaking change for someone, in theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant