Skip to content

Commit

Permalink
Revert "Track empty username and password in PasswordStore."
Browse files Browse the repository at this point in the history
This reverts https://codereview.chromium.org/493123002. There were too many generated crashes.

BUG=407767

Review URL: https://codereview.chromium.org/512673002

Cr-Commit-Position: refs/heads/master@{#292134}
  • Loading branch information
vasilii authored and Commit bot committed Aug 27, 2014
1 parent 6883355 commit 7b9995c
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions components/password_manager/core/browser/login_database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <limits>

#include "base/bind.h"
#include "base/debug/dump_without_crashing.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
Expand Down Expand Up @@ -118,12 +117,6 @@ void AddCallback(int err, sql::Statement* /*stmt*/) {
DLOG(WARNING) << "LoginDatabase::AddLogin updated an existing form";
}

// http://crbug.com/404012. Let's see where the empty fields come from.
void CheckForEmptyUsernameAndPassword(const PasswordForm& form) {
if (form.username_value.empty() && form.password_value.empty())
base::debug::DumpWithoutCrashing();
}

} // namespace

LoginDatabase::LoginDatabase() {
Expand Down Expand Up @@ -359,7 +352,6 @@ void LoginDatabase::ReportMetrics(const std::string& sync_username) {
}

PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
CheckForEmptyUsernameAndPassword(form);
PasswordStoreChangeList list;
std::string encrypted_password;
if (EncryptedString(form.password_value, &encrypted_password) !=
Expand Down Expand Up @@ -403,7 +395,6 @@ PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
}

PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
CheckForEmptyUsernameAndPassword(form);
std::string encrypted_password;
if (EncryptedString(form.password_value, &encrypted_password) !=
ENCRYPTION_RESULT_SUCCESS)
Expand Down

0 comments on commit 7b9995c

Please sign in to comment.