Skip to content

Commit

Permalink
Remove -mimplicit-it=always from skia asm flags.
Browse files Browse the repository at this point in the history
This was added to work around skia issue 297, but that's been fixed for years.
clang's integrated assembler doesn't understand -mimplicit-it=, so as it's not
needed here, just remove it.

BUG=86592,skia:297,124610
R=piman@chromium.org

Review URL: https://codereview.chromium.org/463653002

Cr-Commit-Position: refs/heads/master@{#288830}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288830 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
thakis@chromium.org committed Aug 11, 2014
1 parent 8d25ed5 commit 22ae186
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
7 changes: 0 additions & 7 deletions skia/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -629,13 +629,6 @@ source_set("skia_opts") {
"//third_party/skia/src/opts/memset32_neon.S",
]

cflags += [
# The neon assembly contains conditional instructions which aren't
# enclosed in an IT block. The assembler complains without this
# option. See #86592.
"-Wa,-mimplicit-it=always",
]

# Root build config sets -mfpu=$arm_fpu, which we expect to be neon
# when running this.
if (!arm_use_neon) {
Expand Down
7 changes: 0 additions & 7 deletions skia/skia_library_opts.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,6 @@
[ 'target_arch == "arm"', {
'conditions': [
[ 'arm_version >= 7 and (arm_neon == 1 or arm_neon_optional == 1)', {
'cflags': [
# The neon assembly contains conditional instructions which
# aren't enclosed in an IT block. The assembler complains
# without this option.
# See #86592.
'-Wa,-mimplicit-it=always',
],
'dependencies': [
'skia_opts_neon',
]
Expand Down

0 comments on commit 22ae186

Please sign in to comment.