Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fb4 datatypes #166

Closed
arvanus opened this issue Feb 5, 2021 · 3 comments
Closed

Add support for Fb4 datatypes #166

arvanus opened this issue Feb 5, 2021 · 3 comments
Labels
Firebird 4 Firebird 4 Related help wanted

Comments

@arvanus
Copy link
Collaborator

arvanus commented Feb 5, 2021

New datatypes:

  • INT128
  • DECFLOAT(16)
  • DECFLOAT(34)
  • DECFLOAT
  • TIME [ { WITHOUT | WITH } TIME ZONE ]
  • TIMESTAMP [ { WITHOUT | WITH } TIME ZONE ]
@arvanus arvanus added Firebird 4 Firebird 4 Related help wanted labels Feb 5, 2021
@arvanus
Copy link
Collaborator Author

arvanus commented Aug 28, 2022

@andy-123 could you please take a look at Fb4 data types? I've found a bug and would like to ask you to give a look please

Steps:


CREATE TABLE TABLE_NAME (
    COLUMN_NAME  DECIMAL(18,6) NOT NULL,
    DEC_F2       NUMERIC(38,6)
);
ALTER TABLE TABLE_NAME ADD CONSTRAINT CONSTRAINT_NAME_PK PRIMARY KEY (COLUMN_NAME);
INSERT INTO TABLE_NAME (COLUMN_NAME, DEC_F2) VALUES (1, '123123124123412577766.441231');
select * from table_name;
--Edit manually dec_f2 to value 123123124123412577766.44123
--See that the value changed to 123123124123412577767.444123

Thanks

@andy-123
Copy link
Contributor

andy-123 commented Apr 10, 2023

See fix in PR #306

(Sorry for long time beeing inactive.)

mariuz added a commit that referenced this issue Apr 11, 2023
Int128 does not respect scale (Issue #166)
@arvanus
Copy link
Collaborator Author

arvanus commented May 10, 2023

looks like it's working now, thanks for your effort!
I'm not using any of the new data types now, so lets wait for others reviewing it too
I'll close the issue for now

@arvanus arvanus closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firebird 4 Firebird 4 Related help wanted
Projects
None yet
Development

No branches or pull requests

2 participants