Parsing error on 0 + 48060.774 + 0 + -172808.43 + 0

[gustavolealgtz]

Issue title:

• Why this string cannot be parsed?

Issue content:

I have this in a string "0 + 48060.774 + 0 + -172808.43 + 0" I get parsing error Value was either too large or too small for a Decimal.

I think is becasue is getting blank after minus sign, how can I solve this?

[mariuszgromada]

This is a bit incorrect in terms of math conventions, you should use

"0 + 48060.774 + 0 + (-172808.43) + 0"

But I will check how to solve that

Best regards

[mariuszgromada]

What is the mXparser version do you use?

[mXparser-v.4.4.2 bin .NET 4.5] [0 + 48060.774 + 0 + -172808.43 + 0] checking ...
[0 + 48060.774 + 0 + -172808.43 + 0] lexical error

Encountered "+ -" at line 1, column 19.
Was expecting one of:
    <EOF>
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "^" ...
    "^^" ...
    "#" ...
    "!" ...
    "%" ...
    <EQ> ...
    <NEQ> ...
    "<" ...
    "<=" ...
    ">" ...
    ">=" ...
    <OR> ...
    <AND> ...
    "-->" ...
    "<--" ...
    "-/>" ...
    "</-" ...
    <NAND> ...
    "<->" ...
    <NOR> ...
    <BITWISE> ...
    "(+)" ...

[0 + 48060.774 + 0 + -172808.43 + 0] errors were found.
Problem with expression syntax

[mariuszgromada]

v 4.4.2 behaves correctly, meaning does not allow to calculate this expression

[gustavolealgtz]

I am using v 4.4.2 .NET 4.6.1 Let me know if you need more information.

[mariuszgromada]

Can you share the code?

[gustavolealgtz]

Sorry, I can't, formulas are stored in DB and the data came from Excel and the information is restricted (Sales, Volumes and those stuffs).

[mariuszgromada]

I am not able to replicate your case. The string your provided can not be calculated, you should get syntax error and proper error message. Decimal related error should not appear.

See my test code:

Expression e = new Expression("0 + 48060.774 + 0 + -172808.43 + 0");
bool syntax = e.checkSyntax();
mXparser.consolePrintln("syntax = " + syntax);
mXparser.consolePrintln("error message = ");
mXparser.consolePrintln(e.getErrorMessage());

Result

[mXparser-v.4.4.2 bin .NET 4.6.1] syntax = False
[mXparser-v.4.4.2 bin .NET 4.6.1] error message =
[mXparser-v.4.4.2 bin .NET 4.6.1] [0 + 48060.774 + 0 + -172808.43 + 0] checking ...
[0 + 48060.774 + 0 + -172808.43 + 0] lexical error

Encountered "+ -" at line 1, column 19.
Was expecting one of:
    <EOF>
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "^" ...
    "^^" ...
    "#" ...
    "!" ...
    "%" ...
    <EQ> ...
    <NEQ> ...
    "<" ...
    "<=" ...
    ">" ...
    ">=" ...
    <OR> ...
    <AND> ...
    "-->" ...
    "<--" ...
    "-/>" ...
    "</-" ...
    <NAND> ...
    "<->" ...
    <NOR> ...
    <BITWISE> ...
    "(+)" ...

[0 + 48060.774 + 0 + -172808.43 + 0] errors were found.

[gustavolealgtz]

What does means "Lexical error"?, seems do not understand + - even that the minus sign is followed by a number. I got the same issue when the formula is similar. See the next result:

`[327.1232301 + 0 + 0 + 0 + 515.71749 + 495.3492397 + -4.2768999 + 0.5999997 + 117.3832791] checking ...
[327.1232301 + 0 + 0 + 0 + 515.71749 + 495.3492397 + -4.2768999 + 0.5999997 + 117.3832791] lexical error

Encountered "+ -" at line 1, column 51.
Was expecting one of:

"+" ...
"-" ...
"*" ...
"/" ...
"^" ...
"^^" ...
"#" ...
"!" ...
"%" ...
...
...
"<" ...
"<=" ...
">" ...
">=" ...
...
...
"-->" ...
"<--" ...
"-/>" ...
"</-" ...
...
"<->" ...
...
...
"(+)" ...

[327.1232301 + 0 + 0 + 0 + 515.71749 + 495.3492397 + -4.2768999 + 0.5999997 + 117.3832791] errors were found.
`

[gustavolealgtz]

By the way I will rework to add parenthesis in the numbers to avoid this, I hope you solve this.

[mariuszgromada]

+- is not allowed in math syntax, this is deliberate., you should always bracket this. This is according to math conventions.

You may use user arguments for that.

Best regards

[mariuszgromada]

Lexical error means that this is not according to the defined grammar.

[mariuszgromada]

I will consider allowing this

[mariuszgromada]

If you have arguments that are used to build expression
0 + 48060.774 + 0 + -172808.43 + 0

x = 0
y = 48060.774
z = 0
u = -172808.43
v = 0

simply use
x + y + z + u + v

it will be faster as expression is parsed just once, then you can change arguments value and the results is given much much faster. You will avoid this conventions problems like 0 + -100, according to math standards it should always be specified as 0 + (-100).

Best regards

[Phanquan]

I faced that issue once, It throws error due to this part:

0 + 48060.774 + 0 **+ -**172808.43 + 0

it should be "+" instead of "+-", still, I guess you tried to parse the value into the formula while the value was negative.

[gustavolealgtz]

@Phanquan if you use the data 0 + 48060.774 + 0 + -172808.43 + 0 in an Excel you get the result of -124748, as you can see Excel do not send any error and can deal with this kind of formula. But as said before I will enclose all values in parenthesis to avoid this issue. Thank you for your comment.