Jupyter notebook 5 compatibility #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 5, 2018 13:21
…cluding when HybridContentsManager contains a FileContentsManager), and continue to test that non-empty folders owned by PostgresContentsManager are not deletable.
…on 5.x (ipykernel gets installed with the notebook).
…ed (I think). Rename the notebook 4 and 5 installations to reflect the fact that ipython is no longer a dependency.
…version of IPython beyond checking that it's greater than or equal to 3.
ssanderson
force-pushed
the
ipython6-compat
branch
from
54a2f32 to
7817ff4
Compare
- Drop references to IPython. - Add link to JupyterCon presentation.
|
Closed, using quantopian#46 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds on to quantopian#44 to make the changes suggested by this comment: https://github.com/quantopian/pgcontents/pull/44/files#r192937051
One change here that I was unsure about is I removed the IPython dependency for the Jupyter notebook 4 and 5 versions of the installation (and also renamed those installation targets appropriately). The thing that prompted me to remove it is it's not available on python 2 which meant the
ipy6installation failed on python 2. So I thought about it and couldn't think of a reason why we would need it after IPython 3, so I removed it, but let me know if there's a reason we would still need it.The travis build isn't configured correctly for the build to work on this fork, but you can see in this other PR I opened against the upstream repository that the travis build is passing: quantopian#46
@mariusvniekerk @ssanderson could you guys take a look and let me know what you think?