Add plugin support #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the two main properties for plugins.
fixes #63
Currently only the plugin options really make sense, the plugin implementations aren't really helpful when serialized from C#. We could however add a base class for plugins where you can assign methods with the hooks but that would require some additional code in the interop-layer and is only really feasible after #70. That would mean a class that has all the hooks as
IMethodHandlerproperties which are respected on the interop level. This way you could write C# only plugins for chart.js (what madness) but that's an issue for another day.I have also improved some summaries on the fly just because I was in those classes. In general we don't want to change anything other than what we're actively working on but this is so minor that I thought it makes sense.