Type safe enum deserialization #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix equality stuff, improve and add summaries, prevent recursive ObjectEnums
When deserializing "0" or "123" you would get an int. If the enum has a constructor for double but not for int, it will now convert the value to a double. This might be a rather common case so this special check is worth it. Also add lots of comments and tests plus a very minor performance enhancement. XML-docs updated.
Joelius300
force-pushed
the
type-safe-enum-serialization
branch
from
bbfa1a6 to
26495bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds and tests deserialization support for both
StringEnumandObjectEnum, our two type-safe-enums. Both classes have been refactored. The equality stuff has been fixed, bugs have been eradicated and the documentation has been updated/improved. I have also added lots of tests to test both of these classes and their serialization behaviour.This PR is necessary for #70 because there we also need deserialization whereas we previously only needed serialization.