Coding conventions

.editorconfig

@@ -0,0 +1,183 @@
+# editorconfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Default settings:
+# A newline ending every file
+# Use 4 spaces as indentation
+[*]
+insert_final_newline = true
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+
+[project.json]
+indent_size = 2
+
+# C# files
+[*.cs]
+# New line preferences
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_between_query_expression_clauses = true
+
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_case_contents_when_block = true
+csharp_indent_switch_labels = true
+csharp_indent_labels = one_less_than_current
+
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:suggestion
+
+# avoid this. unless absolutely necessary
+dotnet_style_qualification_for_field = false:warning
+dotnet_style_qualification_for_property = false:warning
+dotnet_style_qualification_for_method = false:warning
+dotnet_style_qualification_for_event = false:warning
+
+# Types: use keywords instead of BCL types, and permit var only when the type is clear
+csharp_style_var_for_built_in_types = false:warning
+csharp_style_var_when_type_is_apparent = false:none
+csharp_style_var_elsewhere = false:warning
+dotnet_style_predefined_type_for_locals_parameters_members = true:warning
+dotnet_style_predefined_type_for_member_access = true:warning
+
+# name all constant fields using PascalCase
+dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = warning
+dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols  = constant_fields
+dotnet_naming_rule.constant_fields_should_be_pascal_case.style    = pascal_case_style
+dotnet_naming_symbols.constant_fields.applicable_kinds   = field
+dotnet_naming_symbols.constant_fields.required_modifiers = const
+dotnet_naming_style.pascal_case_style.capitalization = pascal_case
+
+# static fields should have _ prefix
+dotnet_naming_rule.static_fields_should_have_prefix.severity = warning
+dotnet_naming_rule.static_fields_should_have_prefix.symbols  = static_fields
+dotnet_naming_rule.static_fields_should_have_prefix.style    = static_prefix_style
+dotnet_naming_symbols.static_fields.applicable_kinds   = field
+dotnet_naming_symbols.static_fields.required_modifiers = static
+dotnet_naming_symbols.static_fields.applicable_accessibilities = private, internal, private_protected
+dotnet_naming_style.static_prefix_style.required_prefix = _
+dotnet_naming_style.static_prefix_style.capitalization = camel_case
+
+# internal and private fields should be _camelCase
+dotnet_naming_rule.camel_case_for_private_internal_fields.severity = warning
+dotnet_naming_rule.camel_case_for_private_internal_fields.symbols  = private_internal_fields
+dotnet_naming_rule.camel_case_for_private_internal_fields.style    = camel_case_underscore_style
+dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
+dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal
+dotnet_naming_style.camel_case_underscore_style.required_prefix = _
+dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
+
+# Code style defaults
+csharp_using_directive_placement = outside_namespace:warning
+dotnet_sort_system_directives_first = true
+csharp_prefer_braces = true:refactoring
+csharp_preserve_single_line_blocks = true:none
+csharp_preserve_single_line_statements = false:none
+csharp_prefer_static_local_function = true:suggestion
+csharp_prefer_simple_using_statement = false:none
+csharp_style_prefer_switch_expression = true:suggestion
+
+# Code quality
+dotnet_style_readonly_field = true:suggestion
+dotnet_code_quality_unused_parameters = non_public:suggestion
+
+# Expression-level preferences
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_auto_properties = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:refactoring
+dotnet_style_prefer_conditional_expression_over_return = true:refactoring
+csharp_prefer_simple_default_expression = true:suggestion
+
+# Expression-bodied members
+csharp_style_expression_bodied_methods = true:refactoring
+csharp_style_expression_bodied_constructors = true:refactoring
+csharp_style_expression_bodied_operators = true:refactoring
+csharp_style_expression_bodied_properties = true:refactoring
+csharp_style_expression_bodied_indexers = true:refactoring
+csharp_style_expression_bodied_accessors = true:refactoring
+csharp_style_expression_bodied_lambdas = true:refactoring
+csharp_style_expression_bodied_local_functions = true:refactoring
+
+# Pattern matching
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+
+# Null checking preferences
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+
+# Other features
+csharp_style_prefer_index_operator = false:none
+csharp_style_prefer_range_operator = false:none
+csharp_style_pattern_local_over_anonymous_function = false:none
+
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_after_comma = true
+csharp_space_after_dot = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_after_semicolon_in_for_statement = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_around_declaration_statements = do_not_ignore
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_before_comma = false
+csharp_space_before_dot = false
+csharp_space_before_open_square_brackets = false
+csharp_space_before_semicolon_in_for_statement = false
+csharp_space_between_empty_square_brackets = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_declaration_name_and_open_parenthesis = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_between_square_brackets = false
+
+# Analyzers
+dotnet_code_quality.ca1802.api_surface = private, internal
+dotnet_code_quality.CA2208.api_surface = public
+
+# Xml project files
+[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}]
+indent_size = 2
+
+[*.{csproj,vbproj,proj,nativeproj,locproj}]
+charset = utf-8
+
+# Xml build files
+[*.builds]
+indent_size = 2
+
+# Xml files
+[*.{xml,stylecop,resx,ruleset}]
+indent_size = 2
+
+# Xml config files
+[*.{props,targets,config,nuspec}]
+indent_size = 2
+
+# Shell scripts
+[*.sh]
+end_of_line = lf
+[*.{cmd, bat}]
+end_of_line = crlf

CONTRIBUTING.md

@@ -1,13 +1,13 @@
 # ChartJSBlazor Contributor's guide
-Here is our guidance for how to propose new features and submit contributions via Pull Requests (PR). This is loosely modelled after the [microsoft/terminal](https://github.com/microsoft/terminal/blob/master/doc/contributing.md) and the [www.opensource.guide](https://opensource.guide/how-to-contribute) Guidelines
+Here is our guidance for how to propose new features and submit contributions via Pull Requests (PR). This is loosely modelled after the [microsoft/terminal](https://github.com/microsoft/terminal/blob/master/doc/contributing.md) and the [www.opensource.guide](https://opensource.guide/how-to-contribute) Guidelines.
 
 ## Before you start, file an issue
 To eliminate unnecessary effort and frustration and to ensure no one wastes time please file an issue before doing anything else.
 
 ### How to file an issue
 Before filing a new issue, please look through already existing issues. Search open and closed issues first, it may be that someone else has already found the problem you have and has filed an issue. Please don't clutter up the repo with duplicate issues.  
 
-Also, if something isn't working like you expect it to, I really encourage you to look at the actual [chart.js-docs](https://www.chartjs.org/docs/latest/) before submitting an issue. It's also always helpful if you include a reference to the official docs to back you up when opening an issue about wrong behaviour.  
+Also, if something isn't working like you expect it to, we really encourage you to look at the actual [chart.js-docs](https://www.chartjs.org/docs/latest/) before submitting an issue. It's also always helpful if you include a reference to the official docs to back you up when opening an issue about wrong behaviour.  
 Since there are a lot of options for chart.js, it's really easy to miss small errors which can cause trouble. Show us your research if you find one :)
 
 If no existing issue describes the problem / feature idea you have: Great! - please file a new issue
@@ -16,28 +16,28 @@ If no existing issue describes the problem / feature idea you have: Great! - ple
 - Have a question that you don't see answered in our (sparse) documentation? File an issue
 - Want to know if we're planning on implementing a new feature? File an issue
 - Got a great idea for a new feature? File an issue
-- Found an existing issue that describes yours? Great - upvote and add additional commentary/ info/ repro-steps/ etc.
+- Found an existing issue that describes yours? Great - upvote and add additional commentary / info / repro-steps / etc.
 
 ### Flesh out your issue
 This is based off of [Section 5 of the opensource guide to contributing](https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution)
 
-- **Give Context** help us help you by giving context to the why/ how of your issue
-- **Do some research beforehand** Not knowing everything is ok but show that you tried. Please don't ask questions we can answer with a simple google search or with a link to another issue
-- **Keep them short and direct** The shorter and more direct an issue is, the faster we can understand it and help you
-- **Ask questions** Everyone starts out not knowing anything about a project, don't be afraid to ask us well researched questions
+- **Give Context** help us help you by giving context to the why / how of your issue.
+- **Do some research beforehand** Not knowing everything is ok but show that you tried. Please don't ask questions we can answer with a simple google search or with a link to another issue.
+- **Keep them short and direct** The shorter and more direct an issue is, the faster we can understand it and help you.
+- **Ask questions** Everyone starts out not knowing anything about a project, don't be afraid to ask us well researched questions.
 - **Above all be nice and respectful**
 
 ## Contributing fixes and features
-For those able and willing to help fix issues and/ or implement features:
+For those able and willing to help fix issues and / or implement features:
 
 ### Development
 ### Fork, Clone, Branch and Create your PR
 Once you have created an issue, discussed the issue with other contributors and the maintainer and you have agreed on an approach, it is time to start development:
 
 1. Fork the repo (if you haven't already)
 2. Clone your fork locally
-3. Create & push a feature branch
+3. Create & push a feature branch (make sure to follow our [coding conventions](/Coding-conventions.md))
 4. Rebase onto master to eliminate merge conflicts (if you're unsure what a rebase is, [here](https://hackernoon.com/dont-fear-the-rebase-bca683888dae) is an excellent blog post)
 5. Create a Pull Request
 
-After this process, your PR will be reviewed by the Maintainer and either be accepted, merged into master and closed or be rejected with comments and instructions on improvements and fixes
+After this process, your PR will be reviewed by the Maintainer and either be accepted and merged into master or be rejected with comments and instructions on improvements and fixes.

ChartJs.Blazor.sln

@@ -25,6 +25,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ChartJs.Blazor.Tests", "Cha
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{C7972762-AA87-47E5-85EC-EEF73CA4D4D7}"
 	ProjectSection(SolutionItems) = preProject
+		.editorconfig = .editorconfig
 		global.json = global.json
 	EndProjectSection
 EndProject