Remove Windows dependency (disable uuid_time_generator by default) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables uuid_time_generator by default, allowing it to be re-enabled by defining UUID_TIME_GENERATOR.
If neither UUID_TIME_GENERATOR or UUID_SYSTEM_GENERATOR are included, Windows.h will not be included. This avoids some namespace trouble and compile-time overhead.
I was originally planning to add a disable macro rather than an enable macro, but noticed the warning in the source against using uuid_time_generator in production. Nevertheless, this might break compatibility with some existing projects.