Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cmake project #28

Merged
merged 6 commits into from
Nov 9, 2020
Merged

Refactor cmake project #28

merged 6 commits into from
Nov 9, 2020

Conversation

egor-spk
Copy link
Contributor

@egor-spk egor-spk commented Nov 6, 2020

This pull request add several improvements:

  • optional build of unit test target;
  • optional use of system generator;
  • optional use of span from std;
  • install step;
  • adding to another cmake project via add_subdirectory;
  • adding to another cmake project via the include directive
  • adding to another cmake project via find_package.

@egor-spk
modern cmake project struct
6ac13af 
Added ability to add as a dependency to another cmake project via add_subdirectory
@egor-spk
using std::span from c++20
85ff00a 
- Added the ability to use span from std when standard 20 is enabled.
- Previous catch version didn't work with 20 standard.
@egor-spk
default disable system generator
150f589
@egor-spk
fix running tests
ca94985
@egor-spk
install step and create config-file package
a268dfb
@egor-spk
remove find_dependency for CoreFoundation
c8f730e
@mariusbancila mariusbancila merged commit 1b74bbc into mariusbancila:master Nov 9, 2020
@egor-spk egor-spk deleted the refactor-cmake-project branch November 9, 2020 09:29
@egor-spk egor-spk restored the refactor-cmake-project branch November 9, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egor-spk @mariusbancila