Skip to content

Fix Chunk.modules DeprecationWarning in Webpack 3.x#3

Merged
mariusbalcytis merged 1 commit intomariusbalcytis:masterfrom
steven-pribilinskiy:patch-2
Aug 22, 2017
Merged

Fix Chunk.modules DeprecationWarning in Webpack 3.x#3
mariusbalcytis merged 1 commit intomariusbalcytis:masterfrom
steven-pribilinskiy:patch-2

Conversation

@steven-pribilinskiy
Copy link
Copy Markdown
Contributor

Updates to Chunk.mapModules is not backwards compatible with Webpack 2.x due to breaking changes in webpack/webpack#4764

Following should be added to README:

Install

# for webpack 3
npm install --save-dev extract-text-webpack-plugin
# for webpack 1, 2
npm install --save-dev extract-text-webpack-plugin@0.1.0

@steven-pribilinskiy
Copy link
Copy Markdown
Contributor Author

devDependencies needs to be updated too for CI

Updates to Chunk.mapModules is not backwards compatible with Webpack 2.x due to breaking changes in webpack/webpack#4764
@ghost
Copy link
Copy Markdown

ghost commented Aug 15, 2017

Please merge...

@steven-pribilinskiy
Copy link
Copy Markdown
Contributor Author

@ddeboer-axtion only the owner of the repo @mariusbalcytis can do that

@ghost
Copy link
Copy Markdown

ghost commented Aug 21, 2017

Yeah i know, I was hoping he would read the message ;)

@mariusbalcytis mariusbalcytis merged commit b6973a1 into mariusbalcytis:master Aug 22, 2017
@mariusbalcytis
Copy link
Copy Markdown
Owner

Thanks for the pull request and sorry for the delay.

@steven-pribilinskiy
Copy link
Copy Markdown
Contributor Author

ah, even don't mention it )

@arianrhodsandlot
Copy link
Copy Markdown

Bad news: forEachModule is also deprecated as described here: webpack/webpack#6367 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants