Skip to content

Fix: Quotes around docker compose project directory argument + UTF8 docker logs#331

Open
jellever wants to merge 3 commits intomariotoffia:masterfrom
jellever:master
Open

Fix: Quotes around docker compose project directory argument + UTF8 docker logs#331
jellever wants to merge 3 commits intomariotoffia:masterfrom
jellever:master

Conversation

@jellever
Copy link

@jellever jellever commented Nov 26, 2025

Small fixes:

  • Make sure docker logs are UTF8
  • Make sure docker compose --project-directory argument has quotes around it. If the path had spaces, it broke.
  • Also added quoting to project name, not sure if that one can contain spaces.
  • Added showTimeStamps parameter in container Logs extension method.
  • Bug in which 'sudo docker' was supplied as command to be executed to Executor classes that didn't proper handle that.

@mariotoffia
Copy link
Owner

Thanks @jellever !! - I'll bring this into the v3.0.0 branch since now it won't merge your fixes - sorry 😔

I will put v2.x into "insomnia" this year since it is hard to maintain and focus om v3.x that has a kernel and a driver system with docker CLI, API and podman cli and allows for differences between the drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants