Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds onAttach triggerMethod. #1957

Closed
wants to merge 28 commits into from
Closed

Adds onAttach triggerMethod. #1957

wants to merge 28 commits into from

Commits on Oct 7, 2014

  1. Adds helper methods to AppRouter.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    b2cda35 View commit details
    Browse the repository at this point in the history

  2. region._ensureViewIsIntact 

    Having the region check for view.isDestroyed does two things:

1. It allows you to handle the error of a region.show without the region killing the currentView and breaking without recourse.

2. appending isDestroyed to a Backbone.View on region empty adds the same safety for not re-showing a removed backbone view.

The extra return this; was removed to prevent jslint error for too many statements, and seemed unnecessary
    @paulfalgout @samccone
    paulfalgout authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    ebb0e1c View commit details
    Browse the repository at this point in the history

  3. Improves Application triggerMethod arguments.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    9e6bcaf View commit details
    Browse the repository at this point in the history

  4. Update param types for addRegion method

    @jdaudier @samccone
    jdaudier authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    cd655ee View commit details
    Browse the repository at this point in the history

  5. Removes unnecessary emptyRegions call in LayoutView.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    c2fcd3d View commit details
    Browse the repository at this point in the history

  6. Updates file names; remove unnecessary files.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    9c22308 View commit details
    Browse the repository at this point in the history

  7. Update region-manager.jsdoc

    @jdaudier @samccone
    jdaudier authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    ed6cec5 View commit details
    Browse the repository at this point in the history

  8. Update param types for addRegion method

    @jdaudier @samccone
    jdaudier authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    e91326b View commit details
    Browse the repository at this point in the history

  9. Uses on instead of listenTo for the view show callback.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    1e31fb9 View commit details
    Browse the repository at this point in the history

  10. Improve undefined region show message. 

    Fixes marionettejs#1913
    @samccone
    samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    d6cff4e View commit details
    Browse the repository at this point in the history

  11. adding item-view.jsdoc... again

    @bendman @samccone
    bendman authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    420487b View commit details
    Browse the repository at this point in the history

  12. Add auto addRegions behavior to regionMananger 

    fixes marionettejs#1902
    @samccone
    samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    d7c6d98 View commit details
    Browse the repository at this point in the history

  13. fix indentation for destroy method for proper JSON output :neckbeard:

    @jdaudier @samccone
    jdaudier authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    89eea76 View commit details
    Browse the repository at this point in the history

  14. Aliases Marionette as Mn

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    816efe1 View commit details
    Browse the repository at this point in the history

  15. Updates Module documentation.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    d56571c View commit details
    Browse the repository at this point in the history

  16. Updates Controller documentation.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    2e31d33 View commit details
    Browse the repository at this point in the history

  17. Replaces slice with _.toArray

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    42e9f78 View commit details
    Browse the repository at this point in the history

  18. Updates docs to use getter methods.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    ef01d27 View commit details
    Browse the repository at this point in the history

  19. Adds isNodeAttached helper method.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    e580833 View commit details
    Browse the repository at this point in the history

  20. Adds _getNestedView to Layout and Collection Views.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    d119c51 View commit details
    Browse the repository at this point in the history

  21. Blah blah rebase this lol wut 

    Rebase onto 96d1222
    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    4fe777e View commit details
    Browse the repository at this point in the history

  22. Refactor Application to subclass Object

    @jasonLaster @samccone
    jasonLaster authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    d07d7de View commit details
    Browse the repository at this point in the history

  23. Refactor Behavior to subclass Object

    @jasonLaster @samccone
    jasonLaster authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    fb48d9b View commit details
    Browse the repository at this point in the history

  24. Refactor Region to sub-class Object

    @jasonLaster @samccone
    jasonLaster authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    67dc1a8 View commit details
    Browse the repository at this point in the history

  25. Removes IIFE patterns in source.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    aa03ccf View commit details
    Browse the repository at this point in the history

  26. Removes slice from jshintrc

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    aa80e54 View commit details
    Browse the repository at this point in the history

  27. Adds deprecation notice regarding Callbacks.

    @jamesplease @samccone
    jamesplease authored and samccone committed Oct 7, 2014
    Configuration menu
    Copy the full SHA
    c95ab2f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2014

  1. Adds onAttach triggerMethod.

    @jamesplease
    jamesplease committed Oct 8, 2014
    Configuration menu
    Copy the full SHA
    a4835b1 View commit details
    Browse the repository at this point in the history