-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow override of rendering after a collection sort #1645
Conversation
Nice |
we neeeed some tests to add a hard assertion about the API otherwise we are in the weeds |
Oh damn I forgot tests! :o On Tuesday, 15 July 2014, Sam Saccone notifications@github.com wrote:
|
🎀 |
@samccone updated - also fixed a bug I noticed in the orderChanged logic which was highlight by the tests from @thejameskyle |
👍 |
Rebase please |
Rébase plzzz |
👍 to move to 2.2 |
I want to get this in the 2.1 release because it is a problem that users have reported as being a pain point in 2 |
@samccone we need to get 2.1 out the door. I think we should move everything still open into 2.2 |
This just needs a rebase, it has already been through a review cycle |
the prerelease comes out tomorrow and if we find issues we can address them |
👍 |
## CollectionView's resortView | ||
|
||
By default the `CollectionView` will maintain the order of its `collection` | ||
in the DOM, however on occasions the view may need to re-render to make this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, -> .
👍 |
sorry for the noise. I wanted to link to the issue 1685 |
Fixes: #1570