Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegionManager#hasRegion(regionName) #2594

Closed
jamesplease opened this issue Jun 13, 2015 · 2 comments
Closed

RegionManager#hasRegion(regionName) #2594

jamesplease opened this issue Jun 13, 2015 · 2 comments
Labels
enhancement great for beginners
Milestone
v3.0.0

Comments

@jamesplease
Copy link
Member

I was surprised to find that this doesn't exist!

return Boolean(this.getRegion(regionName));

Also, it goes without saying, but it should be added to the LayoutView prototype.
@ahumphreys87
Copy link
Member

👍 another good suggestion for the big region refactor

@ahumphreys87 ahumphreys87 added this to the v3.0.0 milestone Jun 16, 2015
jisaacks added a commit to jisaacks/backbone.marionette that referenced this issue Jun 19, 2015
@jisaacks
Add ability to check if layout contains region
fb66410 
fixes marionettejs#2594
@jisaacks jisaacks mentioned this issue Jun 19, 2015
Closed
jisaacks added a commit to jisaacks/backbone.marionette that referenced this issue Jun 26, 2015
@jisaacks
Add ability to check if layout contains region
ffcd07b 
fixes marionettejs#2594
Also see marionettejs#2607
@jisaacks jisaacks mentioned this issue Jun 26, 2015
Closed
ahumphreys87 pushed a commit that referenced this issue Jun 26, 2015
@jisaacks @ahumphreys87
Add ability to check if layout contains region
2648520 
fixes #2594
Also see #2607
@ahumphreys87
Copy link
Member

fixed with #2627

ahumphreys87 pushed a commit to ahumphreys87/backbone.marionette that referenced this issue Aug 21, 2016
@jisaacks @ahumphreys87
Add ability to check if layout contains region
30e7c55 
fixes marionettejs#2594
Also see marionettejs#2607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement great for beginners
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Add ability to check if layout contains region jisaacks/backbone.marionette
2 participants
@jamesplease @ahumphreys87