Marionette 2.0 - getChildView doesn't use the child object it is passed

[MeoMix]

    getChildView: function (child) {
        var childView = this.getOption('childView') || this.constructor;

        if (!childView) {
            throwError('A "childView" must be specified', 'NoChildViewError');
        }

        return childView;
    },

Line 2226

and

   getChildView: function (child) {
        var childView = this.getOption('childView');

        if (!childView) {
            throwError('A "childView" must be specified', 'NoChildViewError');
        }

        return childView;
    },

line 1953

[cmaher]

I think this is to demonstrate that subclasses can use the provided to determine what kind of view should be returned. from the docs

I'm not finding any tests for this behavior, but I'm thinking they should be added.

[cmaher]

That said, the same reasoning in #1566 applies here too.

[samccone]

The fix for these is to add Documentation around why the argument is there.

[jamesplease]

The fix for these is to add Documentation around why the argument is there.

Agree with @samccone.

A good number of Backbone and Marionette methods are passed arguments they don't need. This is sometimes intentional, other times not. The time's its intentional is because users will want to override methods to add new, or different functionality, so we give them the information that they need to do that.

The cases we don't need it are when you can just as easily access the property on this within the method.

So if this passed this.collection along as an argument, that would make no sense. But since it's passing a specific model in the collection this becomes rurl useful to people trying to customize the method on a per-model basis.