Skip to content

Commit

Permalink
[CRYPTO] khazad: Use 32-bit reads on key
Browse files Browse the repository at this point in the history
On 64-bit platform, reading 64-bit keys (which is supposed to be
32-bit aligned) at a time will result in unaligned access.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
atsushi-nemoto authored and herbertx committed Jun 26, 2006
1 parent fcc18e8 commit d00e708
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions crypto/khazad.c
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
unsigned int key_len, u32 *flags)
{
struct khazad_ctx *ctx = ctx_arg;
const __be64 *key = (const __be64 *)in_key;
const __be32 *key = (const __be32 *)in_key;
int r;
const u64 *S = T7;
u64 K2, K1;
Expand All @@ -769,8 +769,9 @@ static int khazad_setkey(void *ctx_arg, const u8 *in_key,
return -EINVAL;
}

K2 = be64_to_cpu(key[0]);
K1 = be64_to_cpu(key[1]);
/* key is supposed to be 32-bit aligned */
K2 = ((u64)be32_to_cpu(key[0]) << 32) | be32_to_cpu(key[1]);
K1 = ((u64)be32_to_cpu(key[2]) << 32) | be32_to_cpu(key[3]);

/* setup the encrypt key */
for (r = 0; r <= KHAZAD_ROUNDS; r++) {
Expand Down

0 comments on commit d00e708

Please sign in to comment.