Skip to content

Commit

Permalink
mm/percpu: Remove some local variables in pcpu_populate_pte
Browse files Browse the repository at this point in the history
In function pcpu_populate_pte there are already variable defined,
it can be reused for later use, here remove duplicated local
variables.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
  • Loading branch information
bibo-mao authored and dennisszhou committed Aug 25, 2023
1 parent 5d0c230 commit 41fd59b
Showing 1 changed file with 9 additions and 15 deletions.
24 changes: 9 additions & 15 deletions mm/percpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -3189,32 +3189,26 @@ void __init __weak pcpu_populate_pte(unsigned long addr)
pmd_t *pmd;

if (pgd_none(*pgd)) {
p4d_t *new;

new = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE);
if (!new)
p4d = memblock_alloc(P4D_TABLE_SIZE, P4D_TABLE_SIZE);
if (!p4d)
goto err_alloc;
pgd_populate(&init_mm, pgd, new);
pgd_populate(&init_mm, pgd, p4d);
}

p4d = p4d_offset(pgd, addr);
if (p4d_none(*p4d)) {
pud_t *new;

new = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE);
if (!new)
pud = memblock_alloc(PUD_TABLE_SIZE, PUD_TABLE_SIZE);
if (!pud)
goto err_alloc;
p4d_populate(&init_mm, p4d, new);
p4d_populate(&init_mm, p4d, pud);
}

pud = pud_offset(p4d, addr);
if (pud_none(*pud)) {
pmd_t *new;

new = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE);
if (!new)
pmd = memblock_alloc(PMD_TABLE_SIZE, PMD_TABLE_SIZE);
if (!pmd)
goto err_alloc;
pud_populate(&init_mm, pud, new);
pud_populate(&init_mm, pud, pmd);
}

pmd = pmd_offset(pud, addr);
Expand Down

0 comments on commit 41fd59b

Please sign in to comment.