Skip to content

Commit

Permalink
params.c: fix Smack complaint about parse_args
Browse files Browse the repository at this point in the history
In commit 9fb48c7: "params: add 3rd arg to option handler callback
signature", the if-guard added to the pr_debug was overzealous; no
callers pass NULL, and existing code above and below the guard assumes
as much.  Change the if-guard to match, and silence the Smack
complaint.

CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jimc authored and gregkh committed May 5, 2012
1 parent a85990b commit 1ef9eaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/params.c
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ int parse_args(const char *doing,
/* Chew leading spaces */
args = skip_spaces(args);

if (args && *args)
if (*args)
pr_debug("doing %s, parsing ARGS: '%s'\n", doing, args);

while (*args) {
Expand Down

0 comments on commit 1ef9eaf

Please sign in to comment.