fix main loop hang cli subcommmands#233
Merged
marin-m merged 1 commit intomarin-m:mainfrom Feb 21, 2026
Merged
Conversation
Owner
|
Thanks! |
Contributor
Author
|
Thank you instead for the merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a problem with some legacy CLI subcommands, the
audio-file-to-recognized-songandfingerprint-to-recognized-songhang indefinitely, never exiting.These subcommands created a new
glib::MainContextbut never set it as the thread default. The future scheduled viamain_context.spawn_local()was never polled and this (I think) made the Shazam API request never execute andmain_loop.run()blocked forever doing nothing.And after fixing this, The async block had no
main_loop.quit()call, so after printing the result the main loop would keep running.Tested using
cargo run -- audio-file-to-recognized-song python-version/tests/stupeflip.wav