fix: cell spacing in run, html export #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vertical layout was missing spacing when code was shown.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Jul 27, 2024
| )} | ||
| {/* Shown in read and present */} | ||
| <FloatingOutline /> | ||
| <div className={showCode ? "flex flex-col gap-5" : undefined}> |
There was a problem hiding this comment.
Can you just pass this class to the vertical layout? Avoid a bunch of nesting
There was a problem hiding this comment.
That didn't work because vertical layout has its own nesting. Plus I realized we don't want to put everything (TOC, action buttons) in the flex, just the cell array.
Updated to only wrap in div when needed. So now the DOM is analogous to the CellArray component, which also wraps cells in a flexed div under a VerticalLayoutWrapper.
mscolnick
approved these changes
Jul 27, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.7.13-dev7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical layout was missing spacing when code was shown.