improvement: cleanup markdown, use prose #1892
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
changed the title
size to mo.md()
There was a problem hiding this comment.
On the whole, looks good! Some comments.
I like the responsiveness that this provides. But can we hold off adding size to the public API? I'd like to experiment more and see whether we can get away with only user config or app config.
A couple of things I noticed that would be good to fix before merging:
JSON Output size.
JSON Output embedded in markdown is now unnaturally big. It should have the same formatting as code, since it's monospace. I tried fixing this myself, but wasn't sure how to do it cleanly through tailwind.config.js alone and spent too much time trying to figure it out. Would appreciate help.
This is what I would like it to look like (how it is today, on main):
But in this PR, marimo-json-output is unnaturally big. If marimo-json-output could pick up the same styles that tailwind puts on .prose pre, that would be okay. Here is what it looks like in this PR:
Bullet legibility.
The bullet color is very light now, and hard to see. I'm all for minimalist, unobtrusive design, but this is too minimalist even for me. Can we darken it?
akshayka
changed the title
size to mo.md()
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.7.13-dev2 |
This reverts commit 15fa75a. Tailwind prose broke dark mode colors. Reverting for now so that dark mode users can enjoy the other new features and bug fixes in 0.7.14-0.7.16. We can bring it back when the styling bug is fixed.
Cleanup markdown to allow for dynamic/responsive sizing across marging/padding/font-size/line-height by using
tailwind typography.Now we can easily add
sizetomo.md().In future we can size the whole document (by app config or user config)