Set status to idle after formatters run, not before #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatters can take a long time makes interruption behavior weird however -- descendants don't get canceled if a formatter is interrupted
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Jul 24, 2024
| ) | ||
| assert m4[1]["status"] == "idle" |
There was a problem hiding this comment.
oh this fixes also what i thought was a bug which is "why are there more idle messages, if its already idle". its clearer/cleaner that "running" is repeated
mscolnick
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the cell state machine to count the cell as "running" when output formatters are running.
Sometimes formatters can take a very long time — today, this happens when outputting a very large list or dict. Before this change, formatters that took a long time would lock the kernel without any UI indication in the frontend, making the notebook appear to be broken.
This has the side-effect of making a formatter interruptible, which is helpful if the formatter is taking a very long time to run.
Re: lists/dicts formatting, we should probably lists/dicts/tuples when outputting very large ones, to avoid locking the kernel, but can handle that in another PR.
Draft because haven't tested thoroughly.