-
Notifications
You must be signed in to change notification settings - Fork 34
Add WaitUntil / WaitWhile support to EditorCoroutine #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In addition,it would be better to making the minimum version requirements of the Editor lower. |
Hey, sorry for the late response! I realised I don't get notifications for PR's and am now going through all of my repos.. If you're still up for it, there's two things:
Good idea to support these classes, I like them and they're definitely an addition. |
Thanks for your reply. It is a great suggestion that implementing a handler for CustomYieldInstruction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, but couple things still good to look at.
.gitignore
Outdated
@@ -0,0 +1,36 @@ | |||
[Ll]ibrary/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a .gitignore, any reason to add another one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git reads .gitignore rather than Unity.gitignore. I'll rename Unity.gitignore to the correct name.
Ref: https://git-scm.com/docs/gitignore
/* | ||
* To keep coroutine suspended return true. To let coroutine proceed with execution return false. | ||
* From: https://docs.unity3d.com/ScriptReference/CustomYieldInstruction.html | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things here:
- The indentation is off, as it's spaces instead of tab. So it looks odd on GitHub. Better to fix that.
- I think the comment here is not needed, the code is quite explicit in what it does. The comment only distracts for me.
{ | ||
coroutine.currentYield = new YieldCustomYieldInstruction() | ||
{ | ||
customYield = current as CustomYieldInstruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
} | ||
} | ||
|
||
private bool _status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this still be renamed to status? Last thing 👍
Thanks! 👍 |
No description provided.