docs[DST-572]: Form field guidelines #4174
Open
+300
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dee034 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
the
type:docs
Coverage report
Show files with reduced coverage 🔻
Test suite run success570 tests passing in 78 suites. Report generated by 🧪jest coverage report action from 0dee034 |
|
@OsamaAbdellateef can you edit the title of the PR so its containing the issue and the type of change? |
|
@OsamaAbdellateef also changeset is missing |
sarahgm
reviewed
Oct 14, 2024
|
I reviewed. Someone else maybe should also: @sebald @marcelkoehler @tirado-rx @KadaStrophe ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our form field components share many common features, such as states (disabled, error, readonly) and functionality (label, control, help text). When we revise every single page, this information would be duplicated across multiple component pages, leading to redundancy and potential inconsistencies.
As we are in the process of revising our component pages, now is the perfect time to implement this solution. Establishing a centralized page will streamline future revisions, ensuring consistency and saving time as we update and maintain our documentation.
What should be tested?
Reviewers:
@marigold-ui/developer