fix(android): build issues where dependent libraries can't link RNWC#252
Merged
fix(android): build issues where dependent libraries can't link RNWC#252
Conversation
8ebb5f6 to
3127390
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically addresses all bugs such as:
Details:
There is a bug with the gradle android plugin that causes libraries that depend on the prefab we publish to not be able to find the native libraries.
There are two problems to why this bug occurs:
prefabConfigurePackagetask might run before we build our native libaries. This will cause AGP to treat our library as a "header only" library, in that case it generates a CMake file, which doesn't include the native library and thus linking fails.configureCMake,there is no way to avoid that.Even when the publication in our library changes (because native libs were build) the dependent library wouldn't pick up on that change, as the only place where the AGP would re-run the prefab CLI (which generates the cmake file) is here.
However, no changes are detected, although our prefab publication changed. Thus we manually touch a file to mark it as changed, and that will trigger the CLI to run
Notes: