feat: pan gesture timeout configurable by prop #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodonisko
commented
Oct 12, 2022
| @@ -126,7 +126,8 @@ | |||
| "singleQuote": true, | |||
| "tabWidth": 2, | |||
| "trailingComma": "es5", | |||
| "useTabs": false | |||
| "useTabs": false, | |||
| "semi": false | |||
There was a problem hiding this comment.
This is necessary otherwise it is adding semicolons everywhere on save.
|
Any update on this? I find the timeout to be a bit of a bottleneck on my app as well. |
|
LGTM! 🚀 Thanks for your help @Nodonisko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add option to configure timeout before pan gesture start. This could be very useful especially if you want to disable timeout.
Motivation:
Most of our users was confused with hold timeout and never find out there is something like pan gesture without directly telling them, that they should hold before it starts. Also this behavior without hold timeout is very similar to other apps with same type of graph like Revolut or Kraken app.