-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Indicator #21
Feat: Indicator #21
Conversation
@chrispader do you have a video example of what the indicator looks like? Wondering what the use case would be! |
This is how it looks in the app i originally had the need for this feature. This includes the basic indicator and also a "live" pulse animation. Upload.from.GitHub.for.iOS.MOV |
Not completely finished yet though 😬 |
@chrispader the live pulse looks super nice! |
Have you tried integrating a gradient? Saw some discussion here #11 (comment). |
Not yet! Implemented a lot of features for use cases in one of our own projects at Margelo. I'll talk to @mrousavy on this. If i find some time, i may be implementing this for general use. |
Hey Chris Pader, I was playing around with the Spline interpolation method you integration in this PR. I think it might not be implemented correctly, as there were a few of my datapoints with higher Y positions, got rendered lower |
Hi! Thanks for your input. I already made some changes in a project for one of our clients, that address these issues.. I'll update this PR soon, so everhing works. Sorry for the delay, kinda busy right now 😅😬 |
No worries, thanks for working on this! I have been trying to fix the interpolation issue as well. The current bezier curves only results in such blocky graphs when data is sparse. |
@chrispader, are there any updates on this? |
7ea733e
to
9d66c44
Compare
Not supposed to be closed, just an issue with squashing the commits. To be continued |
b27bbf9
to
9f99135
Compare
b9521ba
to
6d67f4f
Compare
1910ea9
to
4400392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and runs very smoothly - nice work!
Left just a few code org comments to make it cleaner and easy to read, then we're good to go!
Co-authored-by: Marc Rousavy <marcrousavy@hotmail.com>
LGTM! 🚀 nice work chris! |
Allow the user to show an indicator at the end of the graph. This indicator gets hidden once the hold/pan gesture gets started.