Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony's security system #153

Closed
marein opened this issue Oct 16, 2022 · 0 comments · Fixed by #154
Closed

Use Symfony's security system #153

marein opened this issue Oct 16, 2022 · 0 comments · Fixed by #154
Assignees
@marein
Labels
priority:high type:debt

Comments

@marein
Copy link
Owner

marein commented Oct 16, 2022 •
edited
Loading

Previously, it was not necessary to use Symfony's security system. We only needed a persistent anonymous user, which could be well mapped by AssignUserIdOnKernelRequest. This looks different with #6 and #130. With #6 registered users should be able to log in via whatever. With #130 the /metrics endpoint for php shall be secured with basic auth. Instead of adapting the listener AssignUserIdOnKernelRequest to this or building a more complex self-written solution, the security system of Symfony shall be used. This can handle all needs.

This blocks issues #6 and #130.
@marein marein self-assigned this Oct 16, 2022
@marein marein linked a pull request Oct 16, 2022 that will close this issue
Use Symfony's security system #154
Merged
marein added a commit that referenced this issue Oct 26, 2022
@marein
Use Symfony's security system (#154)
b292979 
Upon arrival, ArrivialAuthenticator creates a new user in the
identity context and authenticates them in the session #153.

The current implementation covers what AssignUserIdOnKernelRequest
did before. It adds some complexity, but opens the way for #130 to
secure the /metrics endpoint for php with basic auth, and #6 to eventually
authenticate the user in any way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marein marein

Labels
priority:high type:debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Symfony's security system marein/php-gaming-website
1 participant
@marein