Significant refactoring to dedicated trends subpakcage
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors functionality to add and remove extra marks to a chart. Moved from `charts.OHLCTrends` to `charts.Base`.
Refactors to a base `CaseControls` class those controls of `TrendControls` that can be used for any analysis that outputs sequential cases (be those outputs trends, positions,, etc...).
Refactors from `OHLCTrends` to `OHLCCaseBase` base functionality to overlay an OHLC chart with marks representing multi event analysis.
Provides for subclasses of `guis.BasePrice` to directly `set_initial_prices` so that subclass can get access to charted data.
On `guis` module, refactors out of `TrendsGuiBase`, to `ChartOHLCCaseBase`, common functionality to create a gui that provides for selecting and navigating between cases of multi event analysis, where those cases are displayed on a chart with base `charts.OHLCCaseBase`.
Refactoring and renaming to provide a clearner base off which to develop analyses that can be displayed over OHLC charts. Adds `cases` module.
Moves code specific to trends analysis to dedicated `trends` submodule (maintains access via legacy endpoints).
Refactors classes on `analy` and `analy_alt` out to `movements` and `guis` modules. Consolidates the Trend classes that remain to `analy` module, as `Trends` and `TrendAlt`. Removes `analy_alt`.
Moves code to handle selection of a specific trend case from Movement classes to Chart classes.
Renames from 'Chart*' to 'Gui*'.
Refactors update_trend_mark funcationality from `trends` subpackage to `charts.OHLCCaseBase`.
Makes members of `charts.Groups` enum abstract concepts and extends functionality of `charts.OHLCCaseBase` based on those concepts. Also refactors back from `trends` subpackage to `charts.OHLCCaseBase` functionality to dampen underlying OHLC mark via extending `_create_mark`.
maread99
added
the
code improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality unchanged. Usage through
Analysisunchanged. Locations of classes related to trends have changed, with all these classes now maintained within a dedicated subpackage (although redirects should maintain legacy paths to the principle classes).Refactoring undertaken with the intention of providing a better foundation off which to create other analyses over OHLC charts. The abstract common functionality is referred to as 'case' and 'cases' (a trend Movement is an concrete version of an analysis case).
New functionality eases the adding and management of marks over a OHLC chart.
Refactoring within the new trends subpackage has moved classes related to each of movements, charts and guis out of from
trends.pyandtrends_alt.pyand to dedicated modules. TheTrendsandTrendsAltclasses have in turn been consolidated to theanalymodule.