Add drawdown plot #134
Merged
Add drawdown plot #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes test. Also addresses doc typos in `analysis.py` and `guis.py`.
Adds standalone functions: - get_ath() - get_period_high() - get_pct_off_high()
Concretised on GUI classes as a Lines mark describing the drawdown.
Adds option to `BasePrice` for subclasses to include a drawdown plot and use a `ToggleButtons` widget to select the period over which to evaluate the high. Implementation includes defining a new `prices` attribute on `guis.BasePrice` to hold the prices as currently represented on the chart (the structure of this data can differ from that actually passed through to the chart, this can be an issue as evaluating the drawdown requires knowledge of the 'high' prices whilst some charts, for example `charts.Line` requires only the close price. The `prices` attribure provides for retaining knowledge of all the price data from which new drawdown evaluations can be made). Rearranges order of parameters on some internal 'update' methods on charts.py and guis.py. Also refactors base of `IntervalSelector` to a dedicated `ToggleButtonsHandled` class which the new `DrawdownSelector` also uses.
Extends `test_plot_ohlc` and `test_plot_mult` to test funcionality associated with drawdown plot.
Fixes bug where slider operation becomes erratic when data is intraday and date range is greater than one year. Eratic behaviour caused by, in this context, slider labels being set to a format that excludes the year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option of including a drawdown plot to gui glasses. Implements for
GuiOHLC,GuiLineandGuiMultLine.Involved:
standalone.pymodule.chart.py) to have a secondary plot against a 'right' y-axis.guis.BasePrice(to include adding drawdown period selection widget).Also: