Improve code readability and maintainability in FlaskMVC class and Hook class #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n FlaskMVC class and Hook class In the FlaskMVC class: - Change the variable name `view_func` to `instance_of_controller` to better reflect its purpose. - Instead of calling `view_func()` multiple times, create an instance of the controller class and register it with the hook. - Use the instance of the controller to retrieve the view function for each resource. In the Hook class: - Change the parameter name `ctrl` to `instance_of_controller` to better reflect its purpose. - Use the instance of the controller to retrieve the hook methods. These changes improve the readability and maintainability of the code by using more descriptive variable names and reducing code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FlaskMVC class:
view_functoinstance_of_controllerto better reflect its purpose.view_func()multiple times, create an instance of the controller class and register it with the hook.In the Hook class:
ctrltoinstance_of_controllerto better reflect its purpose.These changes improve the readability and maintainability of the code by using more descriptive variable names and reducing code duplication.
Close #50