Skip to content

Implement HTTP Method Override Middleware #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

Implement HTTP Method Override Middleware #34

merged 3 commits into from
Nov 9, 2023

Conversation

marcuxyz
Copy link
Owner

@marcuxyz marcuxyz commented Jul 12, 2023 •
edited
Loading

Problem

The users cannot create forms with PUT and DELETE methods.

Solution

Create the HTTPMethodOverrideMiddleware, Responsible for creating support to accept PUT, DELETE and PATCH HTTP verbs.

Close #26

@marcuxyz marcuxyz requested a review from taconi July 12, 2023 03:23
@marcuxyz
Copy link
Owner Author

marcuxyz commented Jul 12, 2023 •
edited
Loading

@taconi please review my pr 😃 . Important checks this commit 1a38466

taconi
taconi reviewed Jul 12, 2023
View reviewed changes
@marcuxyz marcuxyz force-pushed the feat/add_spoofing_http_forms branch 3 times, most recently from 49e7cec to 78641a7 Compare November 8, 2023 15:18
@marcuxyz marcuxyz changed the title Implement Support the PUT, DELETE and others HTTP methods Implement HTTP Method Override Middleware Nov 8, 2023
taconi
taconi requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@taconi taconi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a poetry.lock conflict, otherwise it's fine

@marcuxyz
Copy link
Owner Author

marcuxyz commented Nov 9, 2023

There was a poetry.lock conflict, otherwise it's fine

it's done!

@marcuxyz marcuxyz force-pushed the feat/add_spoofing_http_forms branch from dda675f to 1e69e4a Compare November 9, 2023 14:43
@marcuxyz
feat(http_method_override.py): Create the HTTPMethodOverrideMiddlewar…
b607e17 
…e, Responsible for creating support to accept PUT, DELETE and PATCH HTTP verbs.
@marcuxyz marcuxyz force-pushed the feat/add_spoofing_http_forms branch from 1e69e4a to b607e17 Compare November 9, 2023 14:47
@marcuxyz
chore(pyproject.toml): update version from 2.5.0 to 2.7.0 to reflect …
8b24259 
…changes in the project

chore(pyproject.toml): add missing newline at the end of the file for consistency
@marcuxyz
feat(README.md): add support for retrieving and updating message titl…
ad90341 
…e in edit route of MessagesController
@taconi taconi merged commit 2fc33e9 into main Nov 9, 2023
@taconi taconi deleted the feat/add_spoofing_http_forms branch November 9, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taconi taconi taconi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sent to data through form[method=put]
2 participants
@marcuxyz @taconi