Added possibility to set custom bundle where core WebViewJavascriptBridge.js script is located. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat, thanks! |
marcuswestin
added a commit
that referenced
this pull request
Feb 10, 2014
Added possibility to set custom bundle where core WebViewJavascriptBridge.js script is located.
|
If you're up for documenting the method in Readme as well (and adding yourself to list of contributors!), that would be even neater :) |
|
Readme updated. Sorry it took so long :) |
|
Great! PR please? |
|
You mean this one? |
|
Sorry, didn't see :) am traveling and only have a phone to manage this stuff. Thanks man! |
|
No problem. I'm glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added new field and new initialization method to be able to set custom NSBundle where
WebViewJavascriptBridge.js.txtfile is located.I'm developing a static library which uses
WebViewJavascriptBrideand I need to export all resources somehow. With CocoaPods it is easy but if I want to build an.alibrary file I need to export all resources toResources.bundleand place it next to.hheader files. It would be nice if I could just pass additional argument with this bundle so thatWebViewJavascriptBridgecan find it's dependencies there :)If you find it helpful feel free to merge it to your repo. I tried not to make any needless changes.