Skip to content

Conversation

@javache
Copy link
Contributor

@javache javache commented Apr 18, 2015

I added some basic application tests for this library for the CocoaPods Test Jam (http://cocoapods.org/testjam). The test are also ran on Travis CI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this check. In an app that I'm writing, we've pulled the js file from our application bundle and are loading it on our server. This would result in runtime errors in my application while debugging/developing locally.

@marcuswestin
Copy link
Owner

Hey @javache, this has been incredibly useful. I'm a big fan, and super grateful that you took the time to put it together. It has already saved me a noticeable amount of time and effort, and I expect the payoff to only increase with time. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants