Skip to content

fix: xcode-select timeout + OrbStack VM exact match#683

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/setup-xcode-orbstack-fixes
Feb 8, 2026
Merged

fix: xcode-select timeout + OrbStack VM exact match#683
marcusquinn merged 1 commit intomainfrom
bugfix/setup-xcode-orbstack-fixes

Conversation

@marcusquinn
Copy link
Owner

Summary

Addresses two issues from CodeRabbit review on PR #680:

  • Unbounded xcode-select wait loop (Major): The until command -v git loop after xcode-select --install could hang forever if the user cancels or installation fails silently. Added a 5-minute timeout with clear error messaging.
  • OrbStack VM name substring match (Minor): grep -q "$vm_name" could match VMs like aidevops-dev. Changed to grep -qxF for exact full-line fixed-string matching.

Changes

setup.sh (11 insertions, 3 deletions)

  1. xcode-select timeout (~line 1058-1070): Added xcode_wait counter and xcode_max_wait=300 (5 minutes). Loop increments by 5s per iteration and exits with clear error if timeout exceeded.

  2. OrbStack VM exact match (~line 1028): Changed grep -q "$vm_name" to grep -qxF "$vm_name"-x matches whole line, -F treats pattern as fixed string.

Testing

  • ShellCheck: No new violations on modified lines
  • Syntax: bash -n setup.sh passes
  • Linters: All issues pre-existing (no new violations)

…ck VM name

- Add 5-minute timeout to xcode-select --install wait loop to prevent
  hanging forever if user cancels or installation fails silently
- Use grep -qxF for exact VM name matching to prevent substring matches
  (e.g., 'aidevops-dev' no longer falsely matches 'aidevops')

Addresses CodeRabbit feedback from PR #680.
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/setup-xcode-orbstack-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

�[0;34m[INFO]�[0m Latest Quality Status:
SonarCloud: 0 bugs, 0 vulnerabilities, 42 code smells

�[0;34m[INFO]�[0m Recent monitoring activity:
Sun Feb 8 23:08:42 UTC 2026: Code review monitoring started
Sun Feb 8 23:08:42 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 42

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 42
  • VULNERABILITIES: 0

Generated on: Sun Feb 8 23:08:44 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@marcusquinn marcusquinn merged commit ba49571 into main Feb 8, 2026
11 checks passed
@marcusquinn marcusquinn deleted the bugfix/setup-xcode-orbstack-fixes branch February 21, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant