fix: detect fd-find as fdfind on Debian/Ubuntu#241
Conversation
On Debian/Ubuntu, the fd-find package installs the binary as 'fdfind', not 'fd'. The setup script now checks for both commands to correctly detect when fd is already installed.
Summary of ChangesHello @alex-solovyev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughUpdates Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: Fixes 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| local fd_version | ||
| fd_version=$(fd --version 2>/dev/null | head -1 || echo "unknown") | ||
| print_success "fd found: $fd_version" | ||
| elif command -v fdfind >/dev/null 2>&1; then |
There was a problem hiding this comment.
If fdfind exists but fd does not, this reports success even though downstream tooling that invokes fd will still fail in the current shell unless an alias/symlink is configured. Consider warning here (or ensuring the alias setup runs) so fd is actually callable when only fdfind is present.
🤖 Was this useful? React with 👍 or 👎
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the issue of fd-find being installed as fdfind on Debian/Ubuntu by adding a check for fdfind. The changes improve the robustness of the setup_file_discovery_tools function. One minor improvement can be made regarding variable declaration for better code clarity.
| if command -v fd >/dev/null 2>&1; then | ||
| local fd_version | ||
| fd_version=$(fd --version 2>/dev/null | head -1 || echo "unknown") | ||
| print_success "fd found: $fd_version" | ||
| elif command -v fdfind >/dev/null 2>&1; then | ||
| local fd_version | ||
| fd_version=$(fdfind --version 2>/dev/null | head -1 || echo "unknown") | ||
| print_success "fd found (as fdfind): $fd_version" |
There was a problem hiding this comment.
The fd_version variable is declared twice, once in the if block and again in the elif block. For better readability and to avoid redundant declarations, consider declaring fd_version once at the beginning of the setup_file_discovery_tools function or just before the if statement.
| if command -v fd >/dev/null 2>&1; then | |
| local fd_version | |
| fd_version=$(fd --version 2>/dev/null | head -1 || echo "unknown") | |
| print_success "fd found: $fd_version" | |
| elif command -v fdfind >/dev/null 2>&1; then | |
| local fd_version | |
| fd_version=$(fdfind --version 2>/dev/null | head -1 || echo "unknown") | |
| print_success "fd found (as fdfind): $fd_version" | |
| local fd_version | |
| # Check for fd (fd-find on Debian/Ubuntu installs as fdfind) | |
| if command -v fd >/dev/null 2>&1; then | |
| fd_version=$(fd --version 2>/dev/null | head -1 || echo "unknown") | |
| print_success "fd found: $fd_version" | |
| elif command -v fdfind >/dev/null 2>&1; then | |
| fd_version=$(fdfind --version 2>/dev/null | head -1 || echo "unknown") | |
| print_success "fd found (as fdfind): $fd_version" |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Jan 27 03:01:21 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…s warning - Declare fd_version once before if/elif (Gemini suggestion) - Add warning when fdfind exists but fd alias not active (Augment suggestion)
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Jan 27 03:08:26 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
1 participant
Summary
fdfind, notfdfdandfdfindcommandsProblem
On Debian/Ubuntu, after installing
fd-find:fdfind, notfdsetup.shincorrectly reports fd as not installedSolution
Check for both
command -v fdandcommand -v fdfindinsetup_file_discovery_tools().Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.