t1278: Interactive Skill Discovery & Management CLI (aidevops skills)#2030
t1278: Interactive Skill Discovery & Management CLI (aidevops skills)#2030marcusquinn merged 5 commits intomainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughIntroduces a comprehensive skill discovery and management system featuring a new interactive CLI command ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 20 21:11:03 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
- Remove unused SUBAGENT_INDEX variable (SC2034) - Replace local -A associative arrays with temp files for bash 3.2 - Add BOLD color constant missing from shared-constants.sh - Add /skills and aidevops skills to AGENTS.md Skills section - Add Skills row to progressive disclosure domain table - Add skills to Getting Started CLI command list - Update subagent-index.toon script count (81->82)
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AI agent's capabilities by introducing a comprehensive interactive command-line interface for skill discovery and management. It allows users to easily find, explore, and understand the various AI agent skills available, improving usability and accessibility of the system's functionalities. The changes involve adding new scripts and updating existing documentation and the main CLI entry point to support these new features. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 20 21:17:58 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new aidevops skills command for interactive skill discovery and management. The changes include a new helper script skills-helper.sh, updates to the main aidevops.sh CLI, and corresponding documentation. My review focuses on adherence to the repository's shell scripting style guide, robustness, and maintainability. I've identified several areas for improvement, including a high-severity issue with temporary file handling, inconsistent error suppression that violates project rules, and some minor inconsistencies. One comment regarding explicit return statements was removed as its suggestion contradicted an established rule. Applying these suggestions will make the new script more robust and aligned with the project's standards.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
.agents/scripts/skills-helper.sh (1)
29-32:set -euo pipefailplaced aftersource, and the BOLD comment is now stale.Two nits here:
source "${SCRIPT_DIR}/shared-constants.sh"runs withoutset -eactive. If the file is missing, the script silently continues and fails later with a confusing "unbound variable" error on first color use, rather than a clearshared-constants.sh: not foundmessage. Movingset -euo pipefailbefore thesourcecall makes failures self-documenting.The comment on line 31 says "Bold not in shared-constants.sh — define locally", but the commit log records that
BOLDwas added toshared-constants.shin this same PR. The local override is now redundant dead code.♻️ Proposed fix
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" || exit +set -euo pipefail source "${SCRIPT_DIR}/shared-constants.sh" -set -euo pipefail - -# Bold not in shared-constants.sh — define locally -BOLD='\033[1m' - # Configuration🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/scripts/skills-helper.sh around lines 29 - 32, Move the "set -euo pipefail" line above the "source \"${SCRIPT_DIR}/shared-constants.sh\"" call so the script fails fast and surfaces a clear missing-file error from shared-constants.sh, and remove the now-redundant local BOLD definition and its comment (since BOLD is defined in shared-constants.sh) to avoid overriding or duplicating that constant; update the top of the script to enable strict mode before sourcing and delete the BOLD variable and its comment where BOLD is currently declared.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agents/scripts/skills-helper.sh:
- Line 335: The three occurrences of echo wrapping a printf subshell (e.g. echo
"$(printf '=%.0s' $(seq 1 $((${`#category`} + 12))))") trigger ShellCheck SC2005;
replace each with a direct printf call followed by a bare echo for the newline —
e.g. use printf '=%.0s' $(seq 1 $((${`#category`} + 12))) and then echo — removing
the useless echo "$(printf ...)" subshell pattern in the functions/locations
that contain the shown printf expressions.
- Around line 42-60: The four logging functions (log_info, log_success,
log_warning, log_error) currently write to stdout which breaks --json consumers;
modify each function to emit its echo output to stderr instead (e.g., redirect
the echo to >&2 or use printf to >&2) while keeping the same messages and return
value so diagnostics go to stderr and stdout remains clean for JSON output.
- Around line 712-768: The cmd_categories function creates a tempfile via mktemp
but lacks a RETURN trap, so if the function exits early (e.g., under set -e) the
temp file leaks; add a trap 'RETURN' (matching the pattern used in cmd_browse)
immediately after creating cat_counts_file to ensure the temp file is removed on
any return/exit, and ensure the trap cleans up "$cat_counts_file" (and is
removed/reset if needed) so existing explicit rm -f at the end remains a no-op.
In @.agents/subagent-index.toon:
- Line 96: Update the TOON scripts block header so the declared count matches
the actual entries: change the header string
`<!--TOON:scripts[82]{name,purpose}:` to `<!--TOON:scripts[92]{name,purpose}:`
(the closing `-->` remains the same) so TOON parsers won't skip the last 10
script entries.
---
Nitpick comments:
In @.agents/scripts/skills-helper.sh:
- Around line 29-32: Move the "set -euo pipefail" line above the "source
\"${SCRIPT_DIR}/shared-constants.sh\"" call so the script fails fast and
surfaces a clear missing-file error from shared-constants.sh, and remove the
now-redundant local BOLD definition and its comment (since BOLD is defined in
shared-constants.sh) to avoid overriding or duplicating that constant; update
the top of the script to enable strict mode before sourcing and delete the BOLD
variable and its comment where BOLD is currently declared.
marcusquinn
dismissed
coderabbitai[bot]’s stale review
Auto-dismissed: bot review does not block autonomous pipeline
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Fri Feb 20 21:58:52 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
1 participant
WIP - incremental commits
Ref #1975
Summary by CodeRabbit
New Features
Documentation