-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a filter option to search for parts of entries contained in lists #921
Conversation
Will be a QOL feature! Thanks for proposing and contributing. I suggest expressions like "has keyword" or "matches keyword" on this case. And the input component should use a text input rather than tags/multitext input. |
@Acylation Thanks. Currently it seems to be implemented so that each property type only allows one input component type, and I'm not sure how I would elegantly change that. If it's something simple I'm missing I'd be happy if you could add it! |
I saw the build failed, so I've updated the code to fix the issue. |
Now the input type is indicated by operator types
Since the right part is now string rather than array, I've also change the matching functions accordingly. Please don't hesitate to reach out / contribute back if there are any problems. |
When filtering projects, sometimes I want to be able to match parts of entries of lists.
For example if files in a project have list properties containing
california adventure
,hotel california
andcaliforniacation
, then under filter, I can select the option "contains part of" in the drop down, and enter incaliforina
. This will match any files which contain any of the above property entries.I'm uncertain as to how this filter option should be named, and am open to suggestions that might be more descriptive of what the filter option does.