Enhance hover support and fix link open #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
Acylation
added
kind/feature
Acylation
reviewed
Jun 12, 2024
|
Since InternalLink is moving to obsidian-projects, perhaps take a look at my PR to obsidian-svelte: I think we can include it here painlessly Edit: nvm, youre already on it :) |
|
Hi I just saw marcusolsson/obsidian-svelte#9. Thanks for pointing out the problem and the fix! Since we gonna use a mocked Closes #780. |
Acylation
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick little adjustment I was missing: using hover preview to quickly go through notes in Board view.
I also took the opportunity adjust the hover treatment of Table view to a more preferred setup: instead of handling the meta keys in projects, we should register a new hover view source, that way the meta key treatment can be toggled inside Page Preview settings:
Tested and made sure this works with both core Page Preview and the Hover Editor plugin.