call to .iter().any() should be .iter().all()

marcus0x62 · Jan 1, 2024 · 2f21bd3 · 2f21bd3
1 parent 1a4f26e
commit 2f21bd3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/crates/proto/src/udp/udp_client_stream.rs b/crates/proto/src/udp/udp_client_stream.rs
@@ -368,10 +368,9 @@ async fn send_serial_message_inner<S: DnsUdpSocket + Send>(
                 let request_queries = request_message.queries();
                 let response_queries = message.queries();
 
-                if !response_queries.is_empty()
-                    && !response_queries
-                        .iter()
-                        .any(|elem| request_queries.contains(elem))
+                if !response_queries
+                    .iter()
+                    .all(|elem| request_queries.contains(elem))
                 {
                     warn!("detected forged question section: we expected '{:?}', but received '{:?}' from server {}",
                         &request_queries, &response_queries, src);