fix: decouple kanban hjkl navigation from item selection #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sidecar is started from within an existing tmux session, the user needs to press the prefix key twice to detach from the nested session (e.g. Ctrl-b Ctrl-b d). When started outside tmux, a single prefix suffices. Detect TMUX env var at package init time (before main unsets it) and adjust the hint text accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace substring matching in filterTasks with palette.FuzzyMatch for relevance-ranked fuzzy search. Scores Title (3x), ID (2x), EpicTitle (1x). Applies to both the create-workspace modal and standalone task-link modal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, pressing h/j/k/l in kanban view immediately selected the highlighted item—syncing to list state, exiting interactive mode, saving selection, and loading content on every cursor movement. Now hjkl (and g/G) only move the visual cursor; Enter activates the highlighted item. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The kanban Enter handler previously returned early after syncing the selection, which prevented enterInteractiveMode() from ever running. Now it falls through to the shared activation logic (orphaned worktree handling + interactive mode entry). When interactive mode can't start (no agent, feature disabled), falls back to loadSelectedContent() so the preview updates for the new selection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes kanban view navigation so that directional keys (h/j/k/l/g/G) only move the visual cursor without activating the highlighted item. Only Enter now selects and activates.
Previous behavior
Every cursor movement in kanban view (h/j/k/l) immediately:
This made it impossible to browse the kanban without each item getting fully activated on every keypress. Additionally, pressing Enter on the already-selected item (or any item) never entered interactive mode because the kanban handler returned early before reaching enterInteractiveMode().
New behavior
Files changed
internal/plugins/workspace/kanban.go— moveKanbanRow() and moveKanbanColumn() stripped of syncKanbanToList() and applyKanbanSelectionChange() callsinternal/plugins/workspace/keys.go— hjkl/gG return nil in kanban mode; Enter syncs kanban selection then falls through to activation with loadSelectedContent() fallbackKnown issue (not addressed here)
The kanban view status detection for sessions/workspaces is still broken — most items currently land in the Waiting column regardless of actual status. That will be fixed separately.
Test plan