fix: support nested tmux sessions with correct detach hints #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sidecar is started from within an existing tmux session, the user needs to press the prefix key twice to detach from the nested session (e.g. Ctrl-b Ctrl-b d). When started outside tmux, a single prefix suffices. Detect TMUX env var at package init time (before main unsets it) and adjust the hint text accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yashas-salankimatt
force-pushed
the
fix/unset-tmux-for-nested-sessions
branch
from
332f79f to
d33f520
Compare
Merged
23 tasks
Owner
|
Thanks @yashas-salankimatt! This one's in the review queue — we want to test it carefully since nested tmux is tricky territory. Will get to it soon. 🪶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of PR #112 - this one fixes the help text to show the correct key combo for sessions in tmux vs not. The preview text was still left as is in the older PR, which is incorrect.
Summary
TMUXenv var at startup so sidecar's internal tmux sessions can nest independently of the user's outer tmux sessionCtrl-b Ctrl-b d to detach(double prefix needed for nested session)Ctrl-b d to detach(single prefix suffices)Ctrl-aif remapped)Test plan
Ctrl-b Ctrl-b d to detach)Ctrl-b d to detach)C-a) to confirm it's picked up correctly🤖 Generated with Claude Code