Fix/replace jose with jwcrypto #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathan-Furnal
requested review from
ryshoooo and
marcospereirampj
as code owners
Nathan-Furnal
force-pushed
the
fix/replace-jose-with-jwcrypto
branch
from
87b18b8
to
26ce311
Compare
marcospereirampj
approved these changes
Feb 26, 2024
4 tasks
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
python-joseuses thecryptographybackend and notecdsa, it isn't up to date and the issues related to it are discussed in #503.When comparing the python libs mentioned on jwt.io, it seems that
jwcryptois the right mix of up-to-date, featureful and has a helpful maintainer that helped me understanding his lib.Thus, I think we can drop
python-joseand usejwcryptoinstead.