Skip to content

Commit

Permalink
Fix faster builds documentation of enable_nacl
Browse files Browse the repository at this point in the history
When I updated this documentation to include more tips here:

https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#Faster-builds

I recommended use_nacl = false when enable_nacl = false is what is
needed. This fixes that.

A later change added redundant document of jumbo builds and also
misspelled that flag. Fixed.

R=dpranke@chromium.org

Change-Id: Ifa37ba972a58ee06a594768cd6298354ff8e8bd0
Reviewed-on: https://chromium-review.googlesource.com/587809
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490437}
  • Loading branch information
randomascii authored and Commit Bot committed Jul 28, 2017
1 parent c15309b commit fcd3deb
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions docs/windows_build_instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,18 +199,16 @@ in the editor that appears when you create your output directory
(`gn args out/Default`) or on the gn gen command line
(`gn gen out/Default --args="is_component_build = true is_debug = true"`).
Some helpful settings to consider using include:
* `use_jumbo_builds = true` - *Experimental* [Jumbo/unity](jumbo.md) builds.
* `use_jumbo_build = true` - *Experimental* [Jumbo/unity](jumbo.md) builds.
* `is_component_build = true` - this uses more, smaller DLLs, and incremental
linking.
* `use_nacl = false` - this disables Native Client which is usually not needed for
local builds.
* `enable_nacl = false` - this disables Native Client which is usually not
needed for local builds.
* `target_cpu = "x86"` - x86 builds are slightly faster than x64 builds and
support incremental linking for more targets. Note that if you set this but
don't' set use_nacl = false then build times may get worse.
don't' set enable_nacl = false then build times may get worse.
* `remove_webcore_debug_symbols = true` - turn off source-level debugging for
blink to reduce build times, appropriate if you don't plan to debug blink.
* `use_jumbo_build = true` - compile multiple translation units as one, for
faster builds (applies only to some components).
* `win_linker_timing = true` - this should not generally be set but can be
helpful when trying to understand build times or incremental linking failures.

Expand Down

0 comments on commit fcd3deb

Please sign in to comment.