Skip to content

Commit

Permalink
Fix some dead links in docs
Browse files Browse the repository at this point in the history
Fix typo and relative path of each links.

Replace chromoting_build_instructions.md with
old_chromoting_build_instructions.md in
docs/chromoting_android_hacking.md
It was renamed in https://codereview.chromium.org/2526563003

Bug: N/A
Change-Id: Ic6b0a297d66c398131a92563be59d826406b41f4
Reviewed-on: https://chromium-review.googlesource.com/1065956
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560398}
  • Loading branch information
amoseui authored and Commit Bot committed May 21, 2018
1 parent ba7282f commit f916d57
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Amey Jahagirdar <jahagird@amazon.com>
Amit Sarkar <amit.srkr@samsung.com>
Amogh Bihani <amogh.bihani@samsung.com>
Amos Lim <amoseui@gmail.com>
Amos Lim <eui-sang.lim@samsung.com>
Amruth Raj <amruthraj@motorola.com>
Amruth Raj <ckqr36@motorola.com>
Anand Ratn <anand.ratn@samsung.com>
Expand Down Expand Up @@ -242,7 +243,6 @@ Erik Sjölund <erik.sjolund@gmail.com>
Eriq Augustine <eriq.augustine@gmail.com>
Ernesto Mudu <ernesto.mudu@gmail.com>
Etienne Laurin <etienne@atnnn.com>
Euisang Lim <eui-sang.lim@samsung.com>
Evan Peterson <evan.peterson.ep@gmail.com>
Evan Wallace <evan.exe@gmail.com>
Evangelos Foutras <evangelos@foutrelis.com>
Expand Down
2 changes: 1 addition & 1 deletion docs/chromoting_android_hacking.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Chromoting Android Hacking

This guide, which is meant to accompany the
[compilation guide](chromoting_build_instructions.md), explains the process of
[compilation guide](old_chromoting_build_instructions.md), explains the process of
viewing the logs and debugging the CRD Android client. I'll assume you've
already built the APK as described in the aforementioned guide, that you're in
the `src/` directory, and that your binary is at
Expand Down
6 changes: 3 additions & 3 deletions docs/memory/tools.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ If that seems like a lot of tools and complexity, it is [but there's a reason](#
-----------
## <a name="global-memory-dumps"> Global Memory Dumps
Many Chrome subsystems implement the
[`trace_event::MemoryDumpProvider`](../../ase/trace_event/memory_dump_provider.h)
[`trace_event::MemoryDumpProvider`](../../base/trace_event/memory_dump_provider.h)
interface to provide self-reported stats detailing their memory usage. The
Global Memory Dump view provides a snapshot-oriented view of these subsystems
that can be collected and viewed via the chrome://tracing infrastructure.
Expand Down Expand Up @@ -123,7 +123,7 @@ TODO(awong): Write about options to script and the flame graph.
Heap dumps provide extremely detailed data about object allocations and is
useful for finding code locations that are generating a large number of live
allocations. Data is tracked and recorded using the [Out-of-process Heap
Profiler (OOPHP)](../../src/components/services/heap_profiling/README.md).
Profiler (OOPHP)](../../components/services/heap_profiling/README.md).

For the Browser and GPU process, this often quickly finds objects that leak over
time.
Expand All @@ -138,7 +138,7 @@ looking similar due to the nature of DOM node allocation.
`VirtualAlloc()`) will not be tracked.
* Utility processes are currently not profiled.
* Allocations are only recorded after the
[HeapProfilingService](../../src/components/services/heap_profiling/heap_profiling_service.h)
[HeapProfilingService](../../components/services/heap_profiling/heap_profiling_service.h)
has spun up the profiling process and created a connection to the target
process. The HeapProfilingService is a mojo service that can be configured to
start early in browser startup but it still takes time to spin up and early
Expand Down
16 changes: 8 additions & 8 deletions docs/speed/benchmark/harnesses/webrtc_perf.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ For its telemetry benchmarks, WebRTC uses the
[WebRTC GitHub project](https://github.com/webrtc).

These are downloaded by the
[`update_webrtc_cases`](../../../tools/perf/page_sets/update_webrtc_cases)
[`update_webrtc_cases`](../../../../tools/perf/page_sets/update_webrtc_cases)
script into the
[`webrtc_cases`](../../../tools/perf/page_sets/webrtc_cases/)
[`webrtc_cases`](../../../../tools/perf/page_sets/webrtc_cases/)
directory, and then referenced in
[`webrtc_cases.py`](../../../tools/perf/page_sets/webrtc_cases.py),
[`webrtc_cases.py`](../../../../tools/perf/page_sets/webrtc_cases.py),
which controls the user interactions and duration of the test.

The [`webrtc.py`](../../../tools/perf/benchmarks/webrtc.py)
The [`webrtc.py`](../../../../tools/perf/benchmarks/webrtc.py)
benchmark specifies which metrics should be collected for the
test pages, and extra options that we pass to the test to fake the real camera
and skip assing permission to get access to the video and audio from the user.
Expand All @@ -36,7 +36,7 @@ To collect traces and compute metrics you can run the following command

You can filter the pages you want to test using the `--story-tag-filter` flag
with the tags specified in
[`webrtc_cases.py`](../../../tools/perf/page_sets/webrtc_cases.py#127).
[`webrtc_cases.py`](../../../../tools/perf/page_sets/webrtc_cases.py#127).

For example, to run only the *multiple-peerconnections* test page, you can use
the following command:
Expand All @@ -63,7 +63,7 @@ gh-pages branch.**
See the *[multiple-peerconnections](https://github.com/webrtc/test-pages/tree/gh-pages/src/multiple-peerconnections)*
test page for an example.

2. **Edit the [`update_webrtc_cases_script`](../../../tools/perf/page_sets/update_webrtc_cases#21)
2. **Edit the [`update_webrtc_cases_script`](../../../../tools/perf/page_sets/update_webrtc_cases#21)
to reference the page you added, and run it.**

This will download the `index.html` file and the `main.js` file into the
Expand All @@ -76,11 +76,11 @@ to reference the page you added, and run it.**
interactions.**

See the
[`MultiplePeerConnections`](../../../tools/perf/page_sets/webrtc_cases.py#101)
[`MultiplePeerConnections`](../../../../tools/perf/page_sets/webrtc_cases.py#101)
class for example.

4. **Add the story to the `WebrtcPageSet` class.**

See [here](../../../tools/perf/page_sets/webrtc_cases.py#127) for example.
See [here](../../../../tools/perf/page_sets/webrtc_cases.py#127) for example.

5. **Submit your changes as a CL**
2 changes: 1 addition & 1 deletion docs/webui_explainer.md
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ are in flight.

## See also

* WebUI's C++ code follows the [Chromium C++ styleguide](../c++/c++.md).
* WebUI's C++ code follows the [Chromium C++ styleguide](../styleguide/c++/c++.md).
* WebUI's HTML/CSS/JS code follows the [Chromium Web
Development Style Guide](../styleguide/web/web.md)

Expand Down

0 comments on commit f916d57

Please sign in to comment.